Chill's patchpack v14_7

[ChillCore]

And another awesome version. Thank you ChillCore

My pleasure.

EDIT: It happened something weird, though:

It is a BR 420. So it's electric but there is steam.

Hmm? There were some changes in that area recently.
I'll test it in clean trunk in a bit. Downloading yesterdays nightly ...
What vehicle set and version is that exactly?

nice

Thank you.

I noticed also another bug.

... Daylength screwed up when saving and loading ...

When I save your game with daylenght factor 2 it reverts to 1 after loading.
After trying a few times the savegame gets corrupted and asserts "in line 37 of ~/chipp_v11/src/date.cpp: fract < DAY_TICKS"
This particular assert was there already in v10 but I have not yet found the sweet spot, something is wrong there ...
I will run your savegame through a debug build to see, hopefully, what goes wrong where.

That happened to me too; also, after I did that, I was able to fund all industry types from all climates for free.
I also played a scenario (added NewGRFs though) and was able to fund all industries from all climates except the current one (Tropic) for free. I'll post saves later.

That's even stranger ... Awaiting your savegame(s)

I got a compilation warning on Ubuntu Linux 10.10:

Thank you for reporting. I am aware about the compilation warnings but did not get to fixing them yet ...

Just to inform you Seems to work without problems though... Only in Settings.cpp it should really be giving problems, if it wants to, if I read the warnings correctly...

As long as you steer away from the problem areas. (copypaste and daylength both in combination with loading and saving)
I do not like the one in settings.cpp neither.
There is a newer slightly different version of the "save company profile patch" but it shows the same warning ... no much point in updating then.

Further, great patchpack! I really love to play with it

Glad you like it.

Only thing I'm 'missing' is Intrastructure Sharing... But that patch is way too outdated to include, I persume...

IS might be a nice patch to add but I have no clue for the moment how many conflicts there might be when merging or how hard it would be when doing so.
As you say it is a bit outdated although I have not yet checked against what revision the latest version is.
Finally there are some problems with it that open doors to abuse in multiplayer ... (eg you can block the orther player(s) by parking trains on junctions, in front of stations, etc.)

Anyway, I assume most people playing with the patchpack play singleplayer and if someone can provide a working version against recent trunk I may give it a shot.




I have a little request concerning posted savegames.
After downloading I rename them by prefixing your nicks to them. I would apreciate it if you could do that before posting them, if it is not to much trouble.
It helps me remembering what i need to check in each one ... Thank you.

[ChillCore]

Sorry for the double post ... 1 bug less in the patchpack.

EDIT: It happened something weird, though:

It is a BR 420. So it's electric but there is steam.

Hmm? There were some changes in that area recently.
I'll test it in clean trunk in a bit. Downloading yesterdays nightly ...
What vehicle set and version is that exactly?

I was able to reproduce this in clean nightly r21293.
I do not know if it is a bug in OpenTTD or in the DB set however.
If I put four locos behind each other then the smoke does not appear.
An older nightly (pre r21249, r21240 and/or r21236) should be tested to see if the bug is in trunk or in the trainset.

[oberhümer]

Problematic saves.
#1 is where all industries can be funded for free, and, oddly enough, the daylength factor change does not even appear in the gamelog. It should still be visible in reduced income for one year, though.
#2 is the scenario where only nonnative industries could be funded for free. Note that I neither changed any patchpack-introduced setting nor removed any NewGRFs(the latter is the same as in the other save).
Also, merging IS into your patchpack should be rather simple - I don't know any patches it really conflicts with in function, and I managed it easily with a CargoDist version.
Then again, it was at revision 20445, and loading "regular" games didn't work... but perhaps you are a bit better with the saving and loading code?

[ChillCore]

Problematic saves.

Good saves ... problematic newgrf.

It took me longer to find some of the missing grfs then finding the problem ...
Your problem is the manual industries grf.

The version you have is the first and enables all industries from all climates at 0 costs.
I tested that grf once and decided it was not my cup of tea and if IIRC it caused some other trouble too. I do not recall what those problems were but I think they had to do with production levels. I have read some complaints and comments somewhere when it was released ... maybe someone recalls.

I tested this generating new games on clean trunk with the same result so it is not a patchpack problem but a "has-not-read-the-manual-before-using-problem", no offence .
There are a few later versions, I have r2 and r5 after updating my download content from time to time, both do not enable all industries but building costs remains 0.
I do not know how the new versions behave as I have never tested them other than the test above and I have no clue what the parameters should be for it to function correctly, I am not able to help you there.

I have not tested removing it from you savegame but i am 95% sure that doing so will cause trouble in paradise.
However if you disable autosaving and try you might be able to save your game. If your game crashes or misbehaves then you can always go back to the last version you have if you want to finish the game ...

Sorry for the bad news but there simply is no brighter way to bring it to you.

Also, merging IS into your patchpack should be rather simple - I don't know any patches it really conflicts with in function, and I managed it easily with a CargoDist version.
Then again, it was at revision 20445, and loading "regular" games didn't work... but perhaps you are a bit better with the saving and loading code?

I'll have a looksie at the latest version of IS to see if there is a lot of things to bump shortly.
There was a lot of codechanges in trunk since then and the patchpack modifies a lot of syntax also ...
As for the savegame compatibility ... I do not know without looking at the code what might have gone wrong for you (or the author).

[Kogut]

Unfortunately my OpenTTD time is consumed like this -> 10% reading forum, changelog, FlySpray and posting, 4% updating patches , 85% checking things and tracing bugs, 1% actual playing.
I do that from time to time but if I were to do that for all patches I would need days that lasted 72 hours and financial support to turn my hobby into my job.

I am a bit worried that in situation like this keeping to date heap of patches may turn into tedious job (see history of MiniIN). So use your own build, and improve that statistics.

[ChillCore]

Unfortunately my OpenTTD time is consumed like this -> 10% reading forum, changelog, FlySpray and posting, 4% updating patches , 85% checking things and tracing bugs, 1% actual playing.
I do that from time to time but if I were to do that for all patches I would need days that lasted 72 hours and financial support to turn my hobby into my job.

I am a bit worried that in situation like this keeping to date heap of patches may turn into tedious job (see history of MiniIN). So use your own build, and improve that statistics.

Yeah, I should improve those statistics.
I do get to play from time to time, but everytime I do I see something new I want to change/add ...
Luckily I have backwards savegame compatibility now so I can continue my game instead of having to start a new one each time I have a new version.

MiniIn has/had a lot more patches in it ... and yes, some day I will get tired of maintaining mine also but not yet.
Most of the time it is good fun though because i enjoy coding just as much as playing, if not more.
I also enjoy looking at other peoples savegames to see how they do things and almost everytime I look at the code I find/learn something new.
Also by searching for all those missing grfs I find some small jewels from time to time.

Even as a kid I enjoyed messing with code and looking at how things work.
I once have drawn a porsche on a commodore Vic 20, fullscreen, using nothing but "data 1234 5678 9abc def1 ...." <- once for each row of pixels.
Later my dad had a cardridge , red with a white button, that plugged in his commodore 64 that you could use to pause and hack gamecode to cheat. I even used to have an Exploder(tm) for my playstation that did the same thing.
On my first pc real pc, a 486, I created a website about JavaScript and HTML using nothing but notepad, a few books and a few programs to create background images, buttons and flash objects. I still have it but I never finished it and was never published, by now most of the content is outdated but it was good fun.

To end the "ChillCore: Computer history", my first encounter with a computer that had a keyboard was while copying the game called "Marsmannetjes" out of the manual of a Spectrum ZX81, written in basic and all you had to do was slalom between characters, falling from the top of the screen, avoiding them as speed increased over time. I could not save the code and had to write it again each time I wanted to play ... without my father knowing as he would have been mad for me touching his precious.
Good times it were indeed. How things have changed since then ... luckily.

The only thing I regret is that I made some wrong choices when I was young and did not continue studying when I had the chance to do so ... My hobby could have been my job ...

What I am doing now is nothing more than what I have been doing for as long as I can remember ... only on a larger scale and focussed on one project ...
When I get frustrated I play a shooter and imagine the adversary to be unsolved bugs, not that shooting them solves them though .

Also I have been thinking about letting people join to help and giving a bit of the control out of my hands but I am afraid that the one will not now what the other has done at some point while merging or bumping ... checking up on each other is no fun or might be difficult at times. I should have used HG or Git from the beginning for that to be easier but I like svn better ...
That being said if someone really wants to add or has added a patch that he would like to see in the patchpack he can always send me an extended version and by simply comparing the patches I can add the changes to my official version.

ps:
Sorry for the wall of text, I got carried away down on memory lane a bit.

[Dwight_K._Schrute]

wall of text

wow


Hope it's ok if I post a binary???

[oberhümer]

Well, sorry for stealing your time...

[Kogut]

The only thing I regret is that I made some wrong choices when I was young and did not continue studying when I had the chance to do so ... My hobby could have been my job ...

offtopic: Now I should learn math to avoid the same problem.
ontopic: Your patchpack is awesome!

[Dwight_K._Schrute]

offtopic: Now I should learn math to avoid the same problem.

This can be hard with the Patchpack on your computer. I had my final exams in math two weeks ago... and I could not learn for them in the way I wanted to

[ChillCore]

Hope it's ok if I post a binary???

Thank you for the binary and the build log.
I hope people remember to make a backup of their savegames ...

Well, sorry for stealing your time...

That's OK. Some grfs do unexpected things.
I still have to find the worleysidings-v01w.grf though -> Yay another station grf
And that Cindini map just looks awesome ...

The only thing I regret is that I made some wrong choices when I was young and did not continue studying when I had the chance to do so ... My hobby could have been my job ...

offtopic: Now I should learn math to avoid the same problem.
ontopic: Your patchpack is awesome!

Offtopic:
The first thing employers ask when you apply for a job is your degree. Even if you have te skillzz you won't get the job because the guy standing next to you has the needed degree even if he does not now his backside from his frontside.
So yes, study for as long as you can and as hard as you can if you want to achieve your dreams, whatever they may be.
The difference between having a degree and not having one is a good life or surviving. (In the long run)

Ontopic:
Thank you.

offtopic: Now I should learn math to avoid the same problem.

This can be hard with the Patchpack on your computer. I had my final exams in math two weeks ago... and I could not learn for them in the way I wanted to

Dwight ... ? Priorities mate! Don't make me post that smilie again.
I hope you passed them.

[ColdIce]

Well, sorry for stealing your time...

That's OK. Some grfs do unexpected things.
I still have to find the worleysidings-v01w.grf though -> Yay another station grf

feel free to share that grf with us (or link it )

thank you for this new release

[ChillCore]

Well, sorry for stealing your time...

That's OK. Some grfs do unexpected things.
I still have to find the worleysidings-v01w.grf though -> Yay another station grf

feel free to share that grf with us (or link it )

I have found it ... by searching for worley and sidings. Searching for the filename revealed nothing strangely enough...
http://www.tt-forums.net/viewtopic.php?f=26&t=33837 (link in the first post.)
I have not yet tested.

thank you for this new release

I hope it is as stable as the previous version. Enjoy.

[michael blunck]

[DBXL: BR420 "steam"]

I was able to reproduce this in clean nightly r21293.
I do not know if it is a bug in OpenTTD or in the DB set however.
If I put four locos behind each other then the smoke does not appear.
An older nightly (pre r21249, r21240 and/or r21236) should be tested to see if the bug is in trunk or in the trainset.

This is a bug in connection with introduction of visual effects for rvs and ships in OTTD. It´s not a bug in DBXL 0.82. The bug arises only when adding coaches to the BR420 "engine". It still works OK in r21243.

regards
Michael

[ChillCore]

I did some more testing ... the bug was introduced in r21249 to be exact.

Attached are two screenshots.
As you can see, before diesel smoke and electric sparcs were broken for dual headed consists in OpenTTD (¿Still in TTDPatch?).

Would it be much work to adjust the appropriate callback for the BR420's second wagon if wagons are attached?
If I revert that revision all dual headed diesel and electric vehicles are broken again but only the BR420 is broken after 21249. I have not yet found another vehicle with the same problem untill now.
This makes me wonder what is broken ... OpenTTD now or the DBXL set since ... ?
Maybe it was never noticed as OpenTTD was broken before and after fixing it the bug showed?

Anyway as I mentioned before I am not familiar with vehicle coding and would not know what to change where to test.


Regards,
ChillCore.

ps:
I have no screenshot of the electric sparcs but If I recall correctly from my testing they also did not work for the last engine in a dual headed consist pre 21249.

[michael blunck]

I did some more testing ... the bug was introduced in r21249 to be exact.

Thanks for finding out. I´ll take a look, just out of interest.

Attached are two screenshots.
As you can see, before diesel smoke and electric sparcs were broken for dual headed consists in OpenTTD (¿Still in TTDPatch?).

I can´t say exactly. The "diesel" is a SVT, but it´s totally different now in v0.9. I´m not sure if the last unit is a motor car here. I´ll have to do some tests with 0.82 in TTDPatch tomorrow.

Would it be much work to adjust the appropriate callback for the BR420's second wagon if wagons are attached?

I won´t do it from three reasons:

- v0.82 is according to the spec,
- v0.82 is rather old and I don´t have the original sources anymore,
- I don´t recall exactly why the 420´s CB10 returns "00" for attached cars. I *think* this had been done to enable choosing different coaches, but I´m not sure. Changing this would require even more tests. In v0.9 all these trains have been changed fundamentally. There´s no use to spent any work on a 6 year old set which is still working (well, until r21249).

If I revert that revision all dual headed diesel and electric vehicles are broken again but only the BR420 is broken after 21249. I have not yet found another vehicle with the same problem untill now.
This makes me wonder what is broken ... OpenTTD now or the DBXL set since ... ?
Maybe it was never noticed as OpenTTD was broken before and after fixing it the bug showed?

Well, I guess that there´s indeed more than one bug. The first one is a quite old modification of CB10 which would have triggered that particular bug already in the past, but another one seemed to hide it. Now, a recent modification seems to trigger that bug now.

That very first bug was to use CB10 for all trains, not only for those which did set prop1B. That was already against the spec, and should have broken the 420 already years ago.

The whole thing is dependant on the way the 420 is constructed in v0.82, namely by buying the "engine" and attaching coaches (which is quite different to the 420 in v0.9).

regards
Michael

[ChillCore]

Attached are two screenshots.
As you can see, before diesel smoke and electric sparcs were broken for dual headed consists in OpenTTD (¿Still in TTDPatch?).

I can´t say exactly. The "diesel" is a SVT, but it´s totally different now in v0.9. I´m not sure if the last unit is a motor car here. I´ll have to do some tests with 0.82 in TTDPatch tomorrow.

The diesel in the screenshot is the VT-137 and yes it is a double headed one in v0.82. As the last part is smoking (in recent trunk) I assume it is powered.
Also the readme says so and when I bought it came as a pair.
I have also tested a few 2cc diesel trains and they were broken also before r21249.

Thank you for testing TTDPatch. I do not have it installed on this HD yet and I do not recall if it was installed on my previous.

Would it be much work to adjust the appropriate callback for the BR420's second wagon if wagons are attached?

I won´t do it from three reasons:
...

I see.
V0.9? I do not have a v0.9 yet ... is that released? I have v0.5a, v0.5b, v0.82, the ECS extension for v0.82 and the Double Deck Coaches.
I would not mind testing If I had it too.
/me goes digging the internetz.


Regards,
ChillCore.

[Dwight_K._Schrute]

Unfortunately it is not only the BR 420 ...

ICE.png (52.07 KiB) Viewed 5439 times

and stop digging for V0.9. AFAIK ther is no release yet... but I think it would be a nice christmas present for a lot of people

[ChillCore]

Unfortunately it is not only the BR 420 ...

Is that still the DB set? There is one ICE (or more) in the 2cc set too ...
Also now that we know when and where the bug was introduced feel free to report this particular bug in the appropriate thread ... preferably with info how to reproduce. eg. If I attach this wagon to this consist in this configuration this happens.
It is possible to build the BR420 for example in a way that the bug does not show but I need to do some more testing before I can tell for sure how to do it ...

and stop digging for V0.9. AFAIK ther is no release yet... but I think it would be a nice christmas present for a lot of people

Grrrrrr. I was hoping for a test version.
But thank you for the info anyway.



I did some more testing too yesterday with recently posted savegames and the savegame code...

@MagicBuzz:
The Daylenght factor is changed globally when loading a savegame but when changing it in game and saving the new value is not properly saved ... It uses a STDG_VAR instead of a STD_VAR for saving the value and I think that is where "the bug" is ... will need to do some more testing .
I think I nailed the the corrupting savegames bug when saving manually -> assert "in line 37 of ~/chipp_v11/src/date.cpp: fract < DAY_TICKS".
I could not yet reproduce it in my testfolder and the previously mentioned corupted savegame I could load again after messing in the saveloadcode ... Also here I need to do more testing before finding the correct numbers to insert.

@Nickelplate:
I have played your savegame for a year yesterday while leaving the daylenght factor at 30.
I could make towns grow without modifying additional code but it required a lot of input. @see attachment. The sign under the towname mentions population of when I started.
Here is what I did so far.
- I added a lot of local busses.
- I have bought statues in the three cities that are being served.
- I increased train capacity (cloned trains) and changed their orders a bit so that they use all platforms in Suntbridge.
- I funded some new houses in Ronningley a few times and payed for some advertisement.
- I have continued for a little while longer than jan 1925. Charnway had also grown bigger than initial after further increasing the number of trains, but I have not saved it as I want to change the town growth speed first. I wanted to play for a full year but I knew I was not going to finish that yesterday.
- While I was busy messing around I have paid of the loan as that makes a $20.000 difference a year.
I am going to play for another year while setting the town growth speed faster in advanced settings and see what difference that makes. I will then post your savegame so you can see what I did exactly.

@everybody:
- I have found where I have made the error that prevents current trunk savegames from being loaded when there is a HQ present and I have almost solved it.
- Basically I will have to review most of the changes in afterload.cpp (and related files) ...
- After testing some more I will be making my way to the next version as a lot has been fixed in trunk recently ... again.

[michael blunck]

Unfortunately it is not only the BR 420 ...

Ah yes. So, could somebody having experienced that bug, please report it to http://bugs.openttd.org ?

As I´m neither using Chill's patchpack nor an OTTD version >= r21249, I´m not the right person to do it. Nevertheless, I´ll step into a possible discussion, if needed.

From my observation, this bug is due to a combination of a very early change in r5061 and a recent one in r21249.

stop digging for V0.9. AFAIK ther is no release yet... but I think it would be a nice christmas present for a lot of people

Don´t hold your breath for DBXL 0.9. ATM, I´m working on other "Christmas presents".


[edit]

Thank you for testing TTDPatch.

OK. Tested again with r2350, but I think this has always been working in TTDPatch:

effects.png (7.58 KiB) Viewed 4834 times

Sparks also work, but it´s quite hard to get two of them doing so on one picture.
[/edit]

regards
Michael