Station Listing Patch

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
Darkvater
Tycoon
Tycoon
Posts: 3053
Joined: 24 Feb 2003 18:45
Location: Hong Kong

Post by Darkvater »

The last one is not so bad, just a few issues
1. center the station name in the listing vertically, now it's more to the top
2. not all data fits if I have a station with 3-4 cargotypes. This is because of the number behind it, which I think is unnecessary.
3. don't have the selection blackened, have it behave like all other dropdown lists. We do want some form of uniformity.
TrueLight: "Did you bother to read any of the replies, or you just pressed 'Reply' and started typing?"
<@[R-Dk]FoRbiDDeN> "HELP, this litte arrow thing keeps following my mouse, and I can't make it go away."
User avatar
Mad Dog McKill
President
President
Posts: 911
Joined: 13 Nov 2002 10:24
Location: Singapore but originally Moscow

Post by Mad Dog McKill »

RookieTycoon wrote:minor issue: selected sorted blacked completely... any idea why?
Darkvater wrote: 3. don't have the selection blackened, have it behave like all other dropdown lists. We do want some form of uniformity.
Darkvater, he is asking a question and you are not answering :P

Reading too quickly, are we?
OT: By FIREMARK: "Limitation disturbs me very sprites. Goes it throw out limitation?"
My Last.fm Profile
My Facebook Profile
User avatar
acidd_uk
Traffic Manager
Traffic Manager
Posts: 194
Joined: 08 Sep 2004 14:38

Post by acidd_uk »

Doh, beat me to it... :-)

Think that's looking really nice - you could make the window width wider by default (for same reason as DV says). Not many stations will have more than ?4? cargo types waiting...
User avatar
Dextro
Chief Executive
Chief Executive
Posts: 701
Joined: 12 Jan 2005 21:56
Location: Lisboa, Portugal
Contact:

Post by Dextro »

acidd_uk wrote:Doh, beat me to it... :-)

Think that's looking really nice - you could make the window width wider by default (for same reason as DV says). Not many stations will have more than ?4? cargo types waiting...
why not alowing the window to be resizable? (probably setting a max and min width) :)
Uncle Dex Says: Follow the KISS Principle!
User avatar
acidd_uk
Traffic Manager
Traffic Manager
Posts: 194
Joined: 08 Sep 2004 14:38

Post by acidd_uk »

The screeny looks like it already is resizeable...

In fact, you could iterate all the stations before opening the window, and make it as wide as the 'biggest' station needed to be. E.g. If there were only stations with 1 cargo type waiting, then make the window width = 1. If there's a station with 4 cargo types waiting, then make it width = 4 etc.

Also, if the window is too thin to show all waiting cargo-types for a station, maybe add an arrow or a ... symbol on the right to show there are more cargo types waiting.

Looking good!
RookieTycoon
Engineer
Engineer
Posts: 34
Joined: 29 Dec 2004 01:16
Location: Bandung, Indonesia

Post by RookieTycoon »

Darkvater wrote: 1. center the station name in the listing vertically, now it's more to the top
Done...
Darkvater wrote: 2. not all data fits if I have a station with 3-4 cargotypes. This is because of the number behind it, which I think is unnecessary.
it's resizeable. I think the most station only have 2 cargo in it. so I choose to make it only fit for two. if it's have more than two cargo it will truncated, but will written when it get wider (sorry bad english :oops: )
acidd_uk wrote: Also, if the window is too thin to show all waiting cargo-types for a station, maybe add an arrow or a ... symbol on the right to show there are more cargo types waiting.
i like this idea... maybe a '>' will do? or...
Darkvater wrote: 3. don't have the selection blackened, have it behave like all other dropdown lists. We do want some form of uniformity.
when I looke closely (in 640x480) it not blackened completely... there is a gray (too dark gray) :roll:
i will not post anything today, i have to go out of town....
see you tomorrow.
User avatar
Celestar
Director
Director
Posts: 574
Joined: 02 Jul 2004 10:56
Contact:

Post by Celestar »

Don't put a color tag in the string of the dropdown menu, because it doesn't get recolored to white then when selected.

Celestar
RookieTycoon
Engineer
Engineer
Posts: 34
Joined: 29 Dec 2004 01:16
Location: Bandung, Indonesia

Post by RookieTycoon »

Blackened problem resolved. Thank to Celestar Suggestion.
last release there are problem for more thar 2 type of cargo. resolved.
Attachments
station listing.diff
Station Listing Patch agains 1914
(15.11 KiB) Downloaded 173 times
same with the first but, not yet widened.. (this is the &quot;right&quot; word?)
same with the first but, not yet widened.. (this is the "right" word?)
station listing default width.png (9.11 KiB) Viewed 4200 times
Station Listing With for type of cargo
Station Listing With for type of cargo
station listing.png (18.49 KiB) Viewed 4201 times
glimmer
Traffic Manager
Traffic Manager
Posts: 192
Joined: 12 Aug 2003 14:38
Location: Perth, Australia
Contact:

Post by glimmer »

nice mate
RookieTycoon
Engineer
Engineer
Posts: 34
Joined: 29 Dec 2004 01:16
Location: Bandung, Indonesia

Post by RookieTycoon »

New patch again 2154 uploaded to sourceforge. with no exact cargo number. :(
Attachments
station listing.diff
station list patch again 2154
(16 KiB) Downloaded 183 times
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Station Listing Patch

Post by 2007Alain2007 »

I know this is a very old patch but why is this never been put in to trunk or has it and i cant find it
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Benny
Tycoon
Tycoon
Posts: 2185
Joined: 25 Aug 2007 17:03
Location: ~/

Re: Station Listing Patch

Post by Benny »

- delete -
Last edited by Benny on 01 Jul 2009 11:57, edited 1 time in total.
Image
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Station Listing Patch

Post by 2007Alain2007 »

Dose it come up how much cargo is waiting and all that sorry for sounding stupid but were is it i can only see the grean line thing no numbers
For Community Integrated Version http://code.google.com/p/civopenttd/
User avatar
Benny
Tycoon
Tycoon
Posts: 2185
Joined: 25 Aug 2007 17:03
Location: ~/

Re: Station Listing Patch

Post by Benny »

Woops, this is a patch that shows the amount of cargo waiting in numbers. You were right.

So why did this never hit trunk?
Image
2007Alain2007
Chief Executive
Chief Executive
Posts: 658
Joined: 11 Nov 2007 12:06
Contact:

Re: Station Listing Patch

Post by 2007Alain2007 »

Looks like some one just for got about it what a sharm hope some one will take on the task to re update this patch becuse its realy handy to have

see were the cargo is waiting and how much of it faster the clicking like ten times and trying to find the stations

Help run a better railway
For Community Integrated Version http://code.google.com/p/civopenttd/
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Station Listing Patch

Post by Terkhen »

The patch itself is very interesting, but trying to update a four year old patch is close to impossible and probably not very useful. If anyone is interested, I think it should be remade from scratch using new features added to the code since then like the new GUI and the filter framework.
User avatar
adf88
Chief Executive
Chief Executive
Posts: 644
Joined: 14 Jan 2008 15:51
Location: PL

Re: Station Listing Patch

Post by adf88 »

I can write it. This should be a moment.

//EDIT
Ready. Later I'll add button to show/hide numbers and patch for current trunk.
Attachments
0.7.0_numbers_on_station_list.diff
(975 Bytes) Downloaded 106 times
:] don't worry, be happy and checkout my patches
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Station Listing Patch

Post by Terkhen »

It seems like something good can come from extensive grave digging :D

I took the liberty of updating adf88's patch to current trunk. I just had to transform a DrawStringTruncated into a DrawString.
Attachments
waiting_cargo_station_list_r16731.diff
(1017 Bytes) Downloaded 107 times
User avatar
adf88
Chief Executive
Chief Executive
Posts: 644
Joined: 14 Jan 2008 15:51
Location: PL

Re: Station Listing Patch

Post by adf88 »

Updated.

//EDIT
I forgot to notice that I changed the number placement. Now it's on the left, closer to cargo label. Items can be arranged tighter. If you complain I'll revert this ;) . Screen below:
Image
Attachments
0.7.2_numbers_on_station_list.diff
(959 Bytes) Downloaded 96 times
r17288_numbers_on_station_list.diff
(1.06 KiB) Downloaded 113 times
:] don't worry, be happy and checkout my patches
Terkhen
OpenTTD Developer
OpenTTD Developer
Posts: 1034
Joined: 11 Sep 2008 07:32
Location: Spain

Re: Station Listing Patch

Post by Terkhen »

It seems like the window is not redrawn correctly when the number changes (this can be checked easily keeping the window open and looking at an station where cargo is changing).
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 19 guests