[PATCH+IN TRUNK] Delete Signs with CTRL+Click immediately

osai · Post by **osai** » 12 Dec 2007 13:30

In multiplayer games signs are placed very often. A lot of them become unnecessary after a while. I created a very tiny patch for faster deletion of signs. With CTRL + Click the sign it will be deleted immediately without popping up the sign edit window. To avoid abuse of this method, it is currently only available for the owner of the sign.

Though this is the first patch I every showed to the public and its a very small one. Hints and critics are welcome.

Regards,
Osai

littlemikey · Post by **littlemikey** » 12 Dec 2007 13:55

Good work, something us COOPers could use ^_^

DJ Nekkid · Post by **DJ Nekkid** » 12 Dec 2007 14:59

hehe, so my suggestion for "sign dynamite" during the game last night actually paied off?

belugas · Post by **belugas** » 12 Dec 2007 15:20

Good idea. May I suggest another quick approach?
Removed code duplication. Always a good thing to keep in mind

osai · Post by **osai** » 12 Dec 2007 17:07

okay. I didn't want to add it to ShowRenameSignWindow(), because from a logically point of view its not the main job of this function. Though it removes extra lines of code.

Would be cool if you guys like it.

XeryusTC · Post by **XeryusTC** » 12 Dec 2007 17:15

osai wrote:To avoid abuse of this method, it is currently only available for the owner of the sign.

And how hard is it to change ownership again? Click it, press enter, ownership changed...

Nice patch though, it is A LOT faster than the delete button I made a while ago

Bilbo · Post by **Bilbo** » 13 Dec 2007 09:36

XeryusTC wrote:
osai wrote:To avoid abuse of this method, it is currently only available for the owner of the sign.
And how hard is it to change ownership again? Click it, press enter, ownership changed...

Nice patch though, it is A LOT faster than the delete button I made a while ago :)

Well, you can delete other people's sign now anyway with two clicks .... click the sign, press delete. I guess it is rather a protection against accidentally deleting someone else's sign, rather than against any sort of vandalism.

osai · Post by **osai** » 13 Dec 2007 20:38

Bilbo wrote:
XeryusTC wrote:
osai wrote:To avoid abuse of this method, it is currently only available for the owner of the sign.
And how hard is it to change ownership again? Click it, press enter, ownership changed...

Nice patch though, it is A LOT faster than the delete button I made a while ago
Well, you can delete other people's sign now anyway with two clicks .... click the sign, press delete. I guess it is rather a protection against accidentally deleting someone else's sign, rather than against any sort of vandalism.

It's just a kind of protection. Because this function is faster and not as time-consuming as the old method. In my opinion its a little bit of both, isn't it?

ColdIce · Post by **ColdIce** » 13 Dec 2007 20:51

nice one..

And one thing:

osai wrote:Though this is the first patch I every showed to the public and its a very small one.
Regards,
Osai

Hit us with those other patches!

Post by **planetmaker** » 12 Jun 2008 05:47

I like the idea and made an update.

CommanderZ · Post by **CommanderZ** » 12 Jun 2008 10:31

Great! I miss this feature so much in trunk. I hope you will fin your way into it quickly!

Post by **planetmaker** » 12 Jun 2008 11:00

CommanderZ wrote:I hope you will fin your way into it quickly!

I'm glad you like this patch. But I still hope that I will stay out of trunk as I'd not like to become an electronic toy - I don't mind, if the patch finds it way in there, though

. I hope I followed all coding style rules correctly. Submitted to flyspray as #2068.

New version: major internal re-write to better fit the coding requirements for trunk. Thanks SmatZ for advice & criticism.

IN TRUNK (r13501)

osai · Post by **osai** » 12 Jun 2008 22:37

With r13501 this feature is in trunk of OpenTTD... I am happy =)

props pm and SmatZ =)

DJ Nekkid · Post by **DJ Nekkid** » 13 Jun 2008 05:31

yey! Will suit us Opencoop guys perfectly

CommanderZ · Post by **CommanderZ** » 13 Jun 2008 06:57

Congratulations. OTTD is one more little bit better than before.

Transport Tycoon Forums

[PATCH+IN TRUNK] Delete Signs with CTRL+Click immediately

[PATCH+IN TRUNK] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH] Delete Signs with CTRL+Click (trunk r13501)

Re: [PATCH] Delete Signs with CTRL+Click immediately

Re: [PATCH+IN TRUNK] Delete Signs with CTRL+Click immediately

Re: [PATCH+IN TRUNK] Delete Signs with CTRL+Click immediately

Who is online