Infrastructure Sharing

[Gedemon]

I'm still on the code to handle bankrupcy. If I can't get it to work tonight, I'll switch to a lighter version and try to post v0.4 for this WE.

[zombie]

Hi.

Can you update your Infrastructure Sharing mod to be compatible with SVN 13087 ? There was lot of changes in one file depot_gui.cpp, others files/changes are ok.

Can you check that ? THX.

If you don't like to wait for v0.4 I attached updated diff files for revision 13087 and the most recent revision 13097.

Kind regards

Zombie

[planetmaker]

updated to r13134.

Edit: There's one line gone missing, already in zombie's update which I relied on, in depot_gui.cpp as of at least the patch to fit r13097. This makes it impossible to use competitors depots in order to buy vehicles. So far I haven't figured out how to update it to trunk due to the GUI changes. The version to fit r13031 still works and has that line.

[zombie]

Hi.

I updated the patch to recent trunk version. I had to modify some parts of the patch:
- converted dialog for setup of the sharing fees into a class(struct)
- included the special news type NS_COMPANY_SHAREING like in planetmakers diff

I compared the latest version by Gedemon with my diff file and this time everything seems to be in place. You still have to test if everything is fine. In my initial tests I was able to

- buy train/plain/street vehicle in own depot
- buy train/plain/street vehicle in opponents depot
- send train/plain/street vehicle to own station
- send train/plain to opponent's station
- display own dialog with sharing fees
- display opponent's dialog with sharing fees
- change sharing fees

I guess that street vehicles are able to visit an opponent's station as well. In my test game this sharing feature was disabled.

Kind regards

Zombie

[Roujin]

Hi.

I updated the patch to recent trunk version. I had to modify some parts of the patch:
- converted dialog for setup of the sharing fees into a class(struct)
- included the special news type NS_COMPANY_SHAREING like in planetmakers diff
[...]

You should rename it to NS_COMPANY_SHARING (without "E")...

[zombie]

Hi.

Hi.

I updated the patch to recent trunk version. I had to modify some parts of the patch:
- converted dialog for setup of the sharing fees into a class(struct)
- included the special news type NS_COMPANY_SHAREING like in planetmakers diff
[...]

You should rename it to NS_COMPANY_SHARING (without "E")...

I realized this as well but as I didn't add this I decided not to correct it

Kind regards

Zombie

[Gedemon]

be warned I'm still working on next version, I see that I should have released a WIP mid-version, cause I've also made those change. (I mean, sorry for double work)

to finish v0.4, I now need to check every situation when a vehicle can block shared infrastructure. (like when removing a bankrupt companie's plane on an airport, all reserved blocks should be cleared)

[zombie]

Hi.

No apologies. I hope my changes are the same as yours. That would mean that I'm able to understand the code of OpenTTD and your patch. I have never coded a single line of C/C++ myself.

And it's okay that you don't update the patch every day. At the moment it's quite hard to keep up with the devs. The rewrite of the whole gui and create classes for each window has quite a large effect on patch coders and patch maintainers. I had a lot of merge conflicts in the past two weeks. I have my own patch collection and I have to update these patch collection to recent trunk revision. And by now I have found quite a clean way to update patches to current trunk revisions and overcome merge conflicts.

The only really important thing is that you keep updating and improving this incredible patch and perhaps it's ready for trunk some day or maybe trunk is ready for this patch

Kind regards

Zombie

[Ammler]

I played now long time with this patch, for me there is one thing to make.... (or 2)

1. I shouldn't be allowed to stop/start my train in a foreign track.
2. I should be able to start/stop foreign trains on my tracks.

As fast as a train is on my tracks, I am the BOSS about it...

Greets
Ammler

[Gedemon]

yes, that's in the TODO list

[Roest]

2. I should be able to start/stop foreign trains on my tracks.

As fast as a train is on my tracks, I am the BOSS about it...

I disagree here. While of course technically you're the boss and can do whatever you want, your competitors are paying you and you have to provide the best service possible to them. Taking a real world example. By EU laws the DB has to allow competitor trains on her tracks and it's not known they stop them and let them rot somewhere for hours.

[Ammler]

As fast as a train is on my tracks, I am the BOSS about it...

I disagree here. While of course technically you're the boss and can do whatever you want,

Thats all I thought about, technically.

It's only meant for gameplay, else I wouldn't share my tracks.... (YAPP jams are almost impossible to solve else.)

Greets
Ammler

[Toni Babelony]

Isn't it an idea when adding waypoints that only allows your trains to pass and waypoints that allow opponent's trains to pass? Maybe this can be combined with the Routing Restriction patch in that regard.

[planetmaker]

1. I shouldn't be allowed to stop/start my train in a foreign track.
2. I should be able to start/stop foreign trains on my tracks.

I'd like to support this notion. It'd make it probably quite easier to maintain ones own tracks.
Of course this solution has the potential for abuse: trap a foreign train on a piece of your track and let it run there eternally, gaining income for you and only costs without gain for your opponent.

As a 2nd step therefor I propose to grant control to both, train owner AND track owner. A stopped train doesn't cost anything at least, should you be unable to get your train anywhere you need it or to a depot.

[Anunnaki]

On the shared stracks, both players (owner of track and owner of train) must have opportunity to do following tasks:
1) turn train around
2) start/stop train
3) send train to depo
4) ignore signals
That allow both sides to "terorise" each others so no-one would be "winner or loser". But also that give ability to both sides to solve stuck or any problems and prevent "terrorism" .

When company is bancrupted and others player's train is actualy by some of its part on bancupted company's track tile, i suppost the following:
1) Train must inmediatly stop there, where he actualy is.
2) Tracks tiles of bancupted comany under the train will be converted to the actual player company for some real price even he dont have money.

More compicated is situation which is big problem i suppoust end would be needed to solve in future versions:
when someone else is buying company and will not more allow track sharing. I suppoust that in that exactly momment when that happends must:
1) Trains, which are actualy on shared track title will be:
a) denyed to use shared depos
b) send to the depo for service where NO-ONE can change that (but must still react on commands turn,stop/start,ignore signals).
c) when they enter to depo, set denyed to use shared tracks
d) when they have shared depos/stations/signs on theyr destination list, they will stay in depo, others will be released from the depo
2) Trains, which have shared depos/stations/signs on theyr destination list, will be solved by the same way as in point 1.
3) All remainings and new trains must be set to "not use shared tiles/depos/stations" anymore.
4) Afther 1 or 3 months, for any train would be set global settings to not use shared tracks.

EDIT!
Or cleaner/simpler solution which you can easily add to the next version:
When is track sharing turned ON, so it is turned ON for everyone for whole game and noone can turn off that, so problem above dissapears.
Every player can have independent (window) opportunity, to set one price ( commont for income and pay), independend for every of 3 shared service (tracks/stations/depods).
But finaly there would be only one final and common price for all players, independent for every of shared services (one for tracks, one for stations, one for depods). And that would be some arthmetic mean/average of prices set by all players depending on how many stations/track tiles nad depods they have.

Example: how to calculate global price for shared tt (tt=track tiles):
player1 have total of 200tt, he set price on 10
player2 have total of 100tt, he set price on 20
player3 have total of 50tt, he set price on 1
player4 have total of 1tt, he set price on 500
player5 have total of 0tt, he set price on 500

First we need do know how much tt are in the game = 351tt total, as we can see in our example situation. So next step is to calculate, who have how strong power (percent per) on final price, based on amout of tt owned.
per=(AmountOfPlayerTiles*100)/TotalTrackTiles
per1=(200tt * 100)/351tt =57,14
per2=(100tt * 100)/351tt =28,57
per3=(50tt * 100)/351tt =14,29
per4=(1tt * 100)/351tt = 0,29
per5=(0tt * 100)/351tt = 0

Nex step is to calculate player prices, where "wis" is wish price from player:
pri=(per * wis) / 100
pri1=(57.14 * 10) / 100 = 5,714
pri2=(28,57 * 20) / 100 = 5,714
pri3=(14,29 * 1) / 100 = 0,1429
pri4=(0,29 * 500) / 100 = 1,45
pri5=(0 * 500) / 100 = 0

So final price would be pri1+pri2+pri3+pri4+pri5=cca 13,02. The same way (by amount of stations and depods) can be calculated for station sharing and depo sharing service.

PS: there can be good to have predefined maximum player wish price per title/depo/station, beffore the game starts from, maybe in "patch settings" menu.

BTW: Can you release what you have actualy done from v0.4 ? The v0.35 for r13205 would be great .

[lead@inbox]

is it possible in your patch - to make subsidiaries or projects in structure of the parent company? With own budget, expenses, incomes, etc.- analogue of a grouping of transport - only at a level of station, way, transport, etc. It will allow to operate company more effectively - to look profitability of separate projects, etc. and sell parts of your company to another player

[Gedemon]

Isn't it an idea when adding waypoints that only allows your trains to pass and waypoints that allow opponent's trains to pass? Maybe this can be combined with the Routing Restriction patch in that regard.

yes, I've already posted there. If this patch (or a similar patch) can't be adapted, I plan to make a very basic version (like with speed/size and private yes/no) for TS.

As a 2nd step therefor I propose to grant control to both, train owner AND track owner. A stopped train doesn't cost anything at least, should you be unable to get your train anywhere you need it or to a depot.

yes, seems to be the better way to do it.

When company is bancrupted and others player's train is actualy by some of its part on bancupted company's track tile, i suppost the following:
1) Train must inmediatly stop there, where he actualy is.
2) Tracks tiles of bancupted comany under the train will be converted to the actual player company for some real price even he dont have money.

the problem is that a tile can be used by 2 trains of different owner on diagonal tracks.

on bankrupcy, all vehicule on shared infrastructure of bankrupt company are teleported to a depot and stopped. (or sold if no shared depot available, or just deleted if even this can't be done)

that's work fine (afaik ) with my local version.

but there is still a problem :

More compicated is situation which is big problem i suppoust end would be needed to solve in future versions:
when someone else is buying company and will not more allow track sharing. I suppoust that in that exactly momment when that happends must:

that also happens when bankrupt company's vehicle are on shared tracks and must be removed, or when a player change this setting during a game...

1) Trains, which are actualy on shared track title will be:
a) denyed to use shared depos
b) send to the depo for service where NO-ONE can change that (but must still react on commands turn,stop/start,ignore signals).
c) when they enter to depo, set denyed to use shared tracks
d) when they have shared depos/stations/signs on theyr destination list, they will stay in depo, others will be released from the depo
2) Trains, which have shared depos/stations/signs on theyr destination list, will be solved by the same way as in point 1.
3) All remainings and new trains must be set to "not use shared tiles/depos/stations" anymore.
4) Afther 1 or 3 months, for any train would be set global settings to not use shared tracks.

I may use something like that, as I've some issue (with signals and airports block) when just teleporting the vehicle in shared depot.

I thought of giving the vehicle to infrastructure owner if it's a bankrupt case.

(damn, and that just make my think of a potential problem with tracksharing paiement at end of month if one company is bankrupt, and another one is created, taking it's ID. I must check that)

EDIT!
Or cleaner/simpler solution which you can easily add to the next version:
When is track sharing turned ON, so it is turned ON for everyone for whole game and noone can turn off that, so problem above dissapears.

still, there will be issue with vehicles on company bankrupcy.

BTW: Can you release what you have actualy done from v0.4 ? The v0.35 for r13205 would be great .

yes, but be warned this is a WIP, no code cleaning, not enought comment, and some parts buggy.

*TEST VERSION, DON'T USE FOR NORMAL GAME*

but if you want to check the pb with signals and airports, that will help...

r13217_infrastructure_sharing_v0.4c.wip.patch

WIP *for code review, do not use for games*

(125.59 KiB) Downloaded 238 times

[Gedemon]

is it possible in your patch - to make subsidiaries or projects in structure of the parent company? With own budget, expenses, incomes, etc.- analogue of a grouping of transport - only at a level of station, way, transport, etc. It will allow to operate company more effectively - to look profitability of separate projects, etc. and sell parts of your company to another player

no. (sorry for short answer, need to leave now, but basically it's another work than this patch)

[Anunnaki]

still, there will be issue with vehicles on company bankrupcy.

Yes, that was (global price in previous post) only for case that someone turn off track sharing during game or buy company which was bancrupted (and then turns sharings off).
Anyway, in case of real banrupcy and case than no one will buy this company, than that can be sloved by this example:
1) bancrupted company will sold all vehicles,aircrafts,trains...anything
2) but tracks,roads,stations,airports and other stuff stay there, till the momment, when someone buy this company (when no one will, then till end of game)
3) track sharing price will be 3x higher then is normal global sharing price (calculated in my previous post), this will slowly decrease depthn and in long time finaly completly payback whole debth/loan and make profit.
4) no more interest for loan will be calculated, so loan will not be increased
5) on beginning of every year, the loan/debth of bancrupted company will be decreased by 25% or 33% or 50% against last year, so sooner or later the company would be atractive to the other playes with very small/or withouth debth
6) there must be also choice to buy this company be another player every time, maybe somewhere on comapny windows, where you have "sharing" button.

This solve problem at the end of month when payments are calculated/send to the erased bancrupted company, or what with two trains on one rail tile of bancrupted company, and what with this tile. There is than not necessary to teleport trains to depod and delete. But this is little complicated maybe, so take it only like idea maybe for other later releases.

*TEST VERSION, DON'T USE FOR NORMAL GAME*
but if you want to check the pb with signals and airports, that will help...

Thank you very much, i wish to test that in my patch pack EMP (beta) with YAPP, DayLenght, DistantCitys/Industry, ReducedIndustry and ImprovedLoan patchs.

[Grolsch]

Great patch! I hope this gets in trunk someday... Been waiting for this a long time! Keep up the work!