YAPP - Yet Another PBS Patch (now in trunk!)

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Mchl »

Tough luck... Still, I'm full of hope ;)
User avatar
FooBar
Tycoon
Tycoon
Posts: 6553
Joined: 21 May 2007 11:47
Location: The Netherlands
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by FooBar »

Michi_cc wrote:Change the setting wait_for_pbs_path to 255 to disable automatic turning at pbs signals.
Thanks mate. I figured I had to put in 0 there to disable it, but it didn't quite have the expected results...

If you put 255 there by default, I think this wonderful patch is ready for trunk inclusion!
Nickel_Plate
Traffic Manager
Traffic Manager
Posts: 146
Joined: 27 Dec 2004 19:37
Location: Home of the Big Cat

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Nickel_Plate »

Have found changing the setting wait_for_pbs_path to 255 to disable automatic turning at pbs signals stops trains from turning around in stations.

;(
User avatar
FooBar
Tycoon
Tycoon
Posts: 6553
Joined: 21 May 2007 11:47
Location: The Netherlands
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by FooBar »

I don't have that issue...

Check your difficulty settings if you have the option set correctly, or reconsider your station layout.
User avatar
planetmaker
OpenTTD Developer
OpenTTD Developer
Posts: 9432
Joined: 07 Nov 2007 22:44
Location: Sol d

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by planetmaker »

It didn't compile with latest trunk anymore. Updated to trunk r13058
Attachments
yapp_62_r13058.diff
yapp v6.2 for trunk r13058
(197.43 KiB) Downloaded 110 times
User avatar
pavel1269
Route Supervisor
Route Supervisor
Posts: 473
Joined: 03 Dec 2006 13:22
Location: Czech Republic
Contact:

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by pavel1269 »

so,
"wait_for_pbs_path 255" or "wait_for_pbs_path 0"
will stop trains to turn at pbs signal if he wait for a bit long?
Roujin
Tycoon
Tycoon
Posts: 1884
Joined: 08 Apr 2007 04:07

Re: YAPP - Yet Another PBS Patch (New version 6 out!)

Post by Roujin »

pavel1269 wrote:so,
"wait_for_pbs_path 255" or "wait_for_pbs_path 0"
will stop trains to turn at pbs signal if he wait for a bit long?
255.
* @Belugas wonders what is worst... a mom or a wife...
<Lakie> Well, they do the same thing but the code is different.

______________
My patches
check my wiki page (sticky button) for a complete list

ImageImage
ImageImageImageImageImageImageImage
Michi_cc
OpenTTD Developer
OpenTTD Developer
Posts: 619
Joined: 14 Jun 2004 23:27
Location: Berlin, Germany
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by Michi_cc »

Here's a brand new version from the printing press.

Changes:
  • 7.1: automatic train reversal at pbs signals would only work in the right moon phase.
As you might have guessed from the version number, we're savegame incomaptible again, due to trunk changing the savegame version.


-- Michael Lutz
Attachments
yapp_r13225_v7_1_svn.patch
svn compatible patch
(194.77 KiB) Downloaded 164 times
yapp_r13225_v7_1.patch
git diff
(201.54 KiB) Downloaded 94 times
Last edited by Michi_cc on 23 May 2008 23:22, edited 1 time in total.
-- Michael Lutz
User avatar
Digitalfox
Chief Executive
Chief Executive
Posts: 708
Joined: 28 Oct 2004 04:42
Location: Catch the Fox if you can... Almost 20 years and counting!

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by Digitalfox »

Hi Michi_cc, like you have seen, 2 small parts of the code have been included in trunk.. :D

So I guess it's time for a small patch update? :mrgreen:
User avatar
mph
Engineer
Engineer
Posts: 124
Joined: 24 Aug 2007 20:47

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by mph »

I have too much work to do. Lots of procrastination later I compiled version 7 as Dave Woreley might want it. (Not checked it worked yet)
Attachments
yappv07.zip
(2.92 MiB) Downloaded 163 times
previously known as daylight
User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by Ammler »

Heya

I tried new yapp and it does seg fault on clicking to depot, I am trying with trunk... (yes, same in trunk)



Greets
Ammler
Last edited by Ammler on 19 May 2008 11:01, edited 1 time in total.
Anunnaki
Engineer
Engineer
Posts: 64
Joined: 16 Aug 2005 16:09
Location: Prague, Czech Republic

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by Anunnaki »

Can autor update this mod for actual r13170 revision ?
More line was rewritten in new source, so maybe is it time to update/rewrite/optimalise patch.
zombie
Traffic Manager
Traffic Manager
Posts: 153
Joined: 19 May 2005 22:19
Location: Germany

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by zombie »

Hi.

Although I'm not the author of this patch I can provide an updated patch file for revision 13171. I compiled a version with this patch and everything seems to work as expected.

EDIT: attached another updated diff.

Kind regards

Zombie
Attachments
yapp_r13171.patch
(196.14 KiB) Downloaded 103 times
yapp_r13192.patch
(196.3 KiB) Downloaded 114 times
OpenTTD: OpenTTD-Wiki
OpenTTDCoop: Blog, Wiki
My favorite patches: cargo destinations, shared infrastructure
squishycube
Transport Coordinator
Transport Coordinator
Posts: 329
Joined: 05 Oct 2003 14:51
Location: Amsterdam
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by squishycube »

Thanks for that!
I heard the stories that they tell of how they labored for this company which sold it's soul to hell

It's my alter ego in my avatar, not me!
Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by Mchl »

I've just compiled zombie's 13192 update. Seems to be working. Thanks
FunMaker
Engineer
Engineer
Posts: 56
Joined: 16 Jul 2003 00:29
Location: Germany
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by FunMaker »

- need it in trunk :( -
Humour is the last hope for the hopeless
One Hopeless Man
User avatar
Expresso
Tycoon
Tycoon
Posts: 1760
Joined: 09 Aug 2004 00:14
Location: Gouda, the Netherlands

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by Expresso »

Maybe a good idea to break this down in smaller patches, so the smaller pieces can easier be included in trunk?
SmatZ
OpenTTD Developer
OpenTTD Developer
Posts: 351
Joined: 03 Oct 2006 18:26
Location: Prague, Czech Republic
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by SmatZ »

Little parts have already been included. But it is not really reasonable to include any PBS specific code now...
Image
Mchl
Director
Director
Posts: 611
Joined: 05 Jan 2007 15:50
Location: Poland
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by Mchl »

SmatZ wrote:Little parts have already been included. But it is not really reasonable to include any PBS specific code now...
Good to see, that developers seem to be interested in the patch :) Patience is virtue... If we have to wait till trunk is ready, then we'll wait ;)
User avatar
belugas
OpenTTD Developer
OpenTTD Developer
Posts: 1507
Joined: 05 Apr 2005 01:48
Location: Deep down the deepest blue
Contact:

Re: YAPP - Yet Another PBS Patch (New version 7 out!)

Post by belugas »

Tom Petty sang ( way way back then) "the waiting is the hardest part" :D
If you are not ready to work a bit for your ideas, it means they don't count much for you.
OpenTTD and Realism? Well... Here are a few thoughs on the matter.
He he he he
------------------------------------------------------------
Music from the Bloody Time Zones
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 4 guests