Glitch in settings-menu: r14250 + Visual Studio Express 2005

[Zuu]

Hello

When I compile myself, using Visual Studio Express 2005 I get glitches as shown in the attached screenshot.

r14250 self compiled with Visual Studio Express 2005

glitch.png (12.97 KiB) Viewed 2379 times

I've used
* Plain trunk
* Debug/Release (don't matter which, both gives glitches)

How I've ran OpenTTD
* From Visual Studio by pressing F5 (I have all TTD graphics in My Documents)
* By renaming openttd.exe to openttdM.exe and then copy it to my last-nightly-directory and ran it from there. (to make sure it uses exactly the same GRFs as the binaries from compile-farm)


I've verified that last nightly downloaded pre-compiled (binary) from openttd.org do NOT give the named glitches.


I should also mention that this is the first time I've had this problem and that I've successfully compiled binaries before that don't have this glitch. I've found one of those, r14180 + some patch. I've checked out a clean trunk of r14180 and compiled and verified that that now Today don't give any glitches so that it's not (likely) my computer that has gone crazy.


So to clarify: Somewhere between r14180 and r14250 there is likely a change in trunk that gives this glitch in win32 binaries compiled with Visual Studio Express 2005.

If someone else with VS Express 2005 can confirm the glitch I would be happy. I can try other revisions too to either brute-force detect where the change is or if someone suggests a revision to try. But it takes some good minutes each try so I've not done more than these two revisions for now.

[Rubidium]

Looks like OpenTTD is loading the "wrong" (i.e. a too old) openttd[wd].grf. Most likely because it finds another .obg or openttd[dw].grf in another search path, like your home directory, first.

[Zuu]

As suggested on a blog post on #openttdcoop blog I've used -d misc=4 to get the paths that OpenTTD searches for GRFs both with a self-compiled binary and a nightly build. Both residing in the same clean nightly build directory.

Visual Studio compiled r14250:

Code: Select all

dbg: [misc] C:\Documents and Settings\Leif\Skrivbord\OpenTTD\CleanTrunk\ added as search path
dbg: [misc] C:\Documents and Settings\Leif\Mina dokument\OpenTTD\ added as search path
dbg: [misc] C:\Documents and Settings\All Users\Dokument\OpenTTD\ added as search path
dbg: [misc] C:\Documents and Settings\Leif\Skrivbord\OpenTTD\CleanTrunk\ added as search path
dbg: [misc] C:\Documents and Settings\Leif\Mina dokument\OpenTTD\ found as personal directory

Nightly build r14250:

Code: Select all

dbg: [misc] C:\Documents and Settings\Leif\Skrivbord\OpenTTD\CleanTrunk\ added as search path
dbg: [misc] C:\Documents and Settings\Leif\Mina dokument\OpenTTD\ added as search path
dbg: [misc] C:\Documents and Settings\All Users\Dokument\OpenTTD\ added as search path
dbg: [misc] C:\Documents and Settings\Leif\Skrivbord\OpenTTD\CleanTrunk\ added as search path
dbg: [misc] C:\Documents and Settings\Leif\Mina dokument\OpenTTD\ found as personal directory

• C:\Documents and Settings\All Users\Dokument\OpenTTD\
  Does not exist
• C:\Documents and Settings\Leif\Mina dokument\OpenTTD\
  Does only contains the TTD data files (I've temporary renamed my usual OpenTTD directory to OpenTTD_ and made a new clean directory without anything else than the TTD data files.
• C:\Documents and Settings\Leif\Skrivbord\OpenTTD\CleanTrunk\
  win32 binary r14250 unziped to that directory

Is there somewhere else I should look for grf files that it might use? I've used windows search for openttdw.grf and openttdd.grf and found a few over my system but they shouldn't affect OpenTTD unless they are in the paths that OpenTTD lists that it searches right?



Edit:
I should add that I've also booted up my laptop in XP and tested there, but that is also not a completely clean environment.

If someone likes to try and see if they also get the glitch there is a binary attached to this post that contains r14250 + my patch for searching in sign lists. On my desktop r14250 compiled in VS Express 2005 with and without that patch both gives that glitch so it should not matter.

It might have to do with the palette stuff in conjunction with how VS Express 2005 compiles the code. But confirmation from others using that binary and/or using VS Express 2005 would probably be useful to get forward.

[glx]

The problem was in openttd[dw].grf. It's fixed in r14253.