[OTTD] BRTrains - Development Thread

[Leanden]

Ive started work on the BR 374 'Velaro' but the roof looks a bit off, anyone think of a way to better blend into the height increase?

[Leanden]

Some progress, got all the power cars and normal wagons done for the e320.

[Leanden]

Nevermind, i finished it and coded it.

v0.1.7 released.

Feature: BR Class 374 'Velaro'

[Leanden]

Eurostar In Game Preview - e300 TMST and e320 Velaro

[Doorslammer]

08 was just a recolour from the UKRS model I think, so no shape changes took place? Although it's worth a revisit. I' should have something after this Monday (model railway exhibition is in full swing).

EDIT: On a quick set evaluation, just picked the 151 liveries as the wrong way round. Prototype was the aluminium body.

[Leanden]

08 was just a recolour from the UKRS model I think, so no shape changes took place? Although it's worth a revisit. I' should have something after this Monday (model railway exhibition is in full swing).

EDIT: On a quick set evaluation, just picked the 151 liveries as the wrong way round. Prototype was the aluminium body.

Thanks Doorslammer, corrected in the next version. I'm just balancing out running and purchase costs atm.

[Leanden]

v0.1.8 released:

Feature: Global Running and Purchase Costs set.
Fix: BR151 Livery Names Corrected

[jonnie47]

the class 170 only has 1 livery option? not sure if this is an over sight or its not coded in yet. Progress is happening so quick, well done on that.

[Leanden]

There are no other liveries drawn for it, if anyone wants to volunteer drawing the others i will code them in.

[Leanden]

Ive just gone through the graphics i currently have, and as it stands i can code 128 trains with the graphics i have available.

[Leanden]

Hopefully someone can help me as I am rapidly pulling my hair out unable to find any fault with my code!!

Basically i am refitting my Eurostars to show the new GNER livery but the TBK and DMb wagons refuse to be repainted!

RefitFault.png (5.1 KiB) Viewed 6728 times

[+] Spoiler

Code: Select all

spriteset(spriteset_BR373_Purchase, "gfx/BR373.png") {
	template_purchase(0, 0)
}

spriteset(spriteset_BR373_2_Purchase, "gfx/BR373_GNER.png") {
	template_purchase(0, 0)
}

spriteset(spriteset_BR373_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 13)
}

spriteset(spriteset_BR373MS_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 38)
}

spriteset(spriteset_BR373TS_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 63)
}

spriteset(spriteset_BR373TBK_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 88)
}

spriteset(spriteset_BR373TF_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 63)
}

spriteset(spriteset_BR373TBF_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 63)
}

spriteset(spriteset_BR373MSb_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 113)
}

spriteset(spriteset_BR373DMb_Eurostar, "gfx/BR373.png") {
	template_train32px(0, 138)
}

spriteset(spriteset_BR373_GNER, "gfx/BR373.png") {
	template_train32px(0, 163)
}

spriteset(spriteset_BR373MS_GNER, "gfx/BR373.png") {
	template_train32px(0, 188)
}

spriteset(spriteset_BR373TS_GNER, "gfx/BR373.png") {
	template_train32px(0, 213)
}

spriteset(spriteset_BR373TBK_GNER, "gfx/BR373.png") {
	template_train32px(0, 238)
}

spriteset(spriteset_BR373TF_GNER, "gfx/BR373.png") {
	template_train32px(0, 213)
}

spriteset(spriteset_BR373TBF_GNER, "gfx/BR373.png") {
	template_train32px(0, 213)
}

spriteset(spriteset_BR373MSb_GNER, "gfx/BR373.png") {
	template_train32px(0, 263)
}

spriteset(spriteset_BR373DMb_GNER, "gfx/BR373.png") {
	template_train32px(0, 288)
}

switch(FEAT_TRAINS,SELF, sw_BR373,cargo_subtype){
    0:	spriteset_BR373_Eurostar;
	1:	spriteset_BR373_GNER;
}

switch(FEAT_TRAINS,SELF, sw_BR373MS,cargo_subtype){
    0:	spriteset_BR373MS_Eurostar;
	1:	spriteset_BR373MS_GNER;
}

switch(FEAT_TRAINS,SELF, sw_BR373TS,cargo_subtype){
    0:	spriteset_BR373TS_Eurostar;
	1:	spriteset_BR373TS_GNER;
}

switch(FEAT_TRAINS,SELF, sw_BR373TBK,cargo_subtype){
    0:	spriteset_BR373TBK_Eurostar;
	1:	spriteset_BR373TBK_GNER;
}

switch(FEAT_TRAINS,SELF, sw_BR373TF,cargo_subtype){
    0:	spriteset_BR373TF_Eurostar;
	1:	spriteset_BR373TF_GNER;
}

switch(FEAT_TRAINS,SELF, sw_BR373TBF,cargo_subtype){
    0:	spriteset_BR373TBF_Eurostar;
	1:	spriteset_BR373TBF_GNER;
}

switch(FEAT_TRAINS,SELF, sw_BR373MSb,cargo_subtype){
    0:	spriteset_BR373MSb_Eurostar;
	1:	spriteset_BR373MSb_GNER;
}

switch(FEAT_TRAINS,SELF, sw_BR373DMb,cargo_subtype){
    0:	spriteset_BR373DMb_Eurostar;
	1:	spriteset_BR373DMb_GNER;
}

switch (FEAT_TRAINS, SELF, switch_articulated_BR373, extra_callback_info1) {
	1: return item_373MS;
	2..5: return item_373TS;
	6: return item_373TBK;
	7..8: return item_373TF;
	9..10: return item_373TBF;
	11..12: return item_373TF;
	13: return item_373TBK;
	14..17: return item_373TS;
	18: return item_373MSb;
	19: return item_373DMb;
    return CB_RESULT_NO_MORE_ARTICULATED_PARTS; //stop adding vehicle parts
}

switch (FEAT_TRAINS, SELF, switch_articulated_BR373_2, extra_callback_info1) {
	1: return item_373MS;
	2..4: return item_373TS;
	5: return item_373TBK;
	6: return item_373TF;
	7..8: return item_373TBF;
	9: return item_373TF;
	10: return item_373TBK;
	11..13: return item_373TS;
	14: return item_373MSb;
	15: return item_373DMb;
    return CB_RESULT_NO_MORE_ARTICULATED_PARTS; //stop adding vehicle parts
}

switch(FEAT_TRAINS,SELF,sw_BR373_cargo_subtype_text,cargo_subtype){
    0:	return string(str_Eurostar);
	1:	return string(str_GNER);
       return CB_RESULT_NO_TEXT;
}

switch(FEAT_TRAINS,SELF,sw_BR373_2_cargo_subtype_text,cargo_subtype){
    0:	return string(str_Eurostar);
	1:	return string(str_GNER);
       return CB_RESULT_NO_TEXT;
}

item (FEAT_TRAINS, item_BR373, 80) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			ALL_CLIMATES;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					247;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_MU;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							16400 hp;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					50;
		weight:							752 ton;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	additional_text:					return(string(str_purchase_loco_with_liveries,string(str_purchase_type_emu),string(str_route_2),string(str_BR373_usage),string(str_BR373_eos),string(str_BR373_liveries)));
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	cargo_subtype_text:					sw_BR373_cargo_subtype_text;
	articulated_part:        			switch_articulated_BR373;
	default: 							sw_BR373;
	purchase:							spriteset_BR373_Purchase;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_BR373_2, 97) {
	property {
		name: 							string(STR_NAME_BR373_2);
		climates_available: 			ALL_CLIMATES;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					225;
		running_cost_factor:			226;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_MU;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							16400 hp;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					50;
		weight:							665 ton;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	additional_text:					return(string(str_purchase_loco_with_liveries,string(str_purchase_type_emu),string(str_route_2),string(str_BR373_2_usage),string(str_BR373_2_eos),string(str_BR373_2_liveries)));
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	cargo_subtype_text:					sw_BR373_cargo_subtype_text;
	articulated_part:        			switch_articulated_BR373_2;
	default: 							sw_BR373;
	purchase:							spriteset_BR373_2_Purchase;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_373MS, 81) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			NO_CLIMATE;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					248;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_NO_BREAKDOWN_SMOKE;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							0;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					48;
		weight:							0;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	default: 							sw_BR373MS;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_373TS, 82) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			NO_CLIMATE;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					248;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_NO_BREAKDOWN_SMOKE;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							0;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					56;
		weight:							0;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	default: 							sw_BR373TS;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_373TBK, 83) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			NO_CLIMATE;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					248;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_NO_BREAKDOWN_SMOKE;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							0;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					0;
		weight:							0;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	default: 							sw_BR373TBK;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_373TF, 84) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			NO_CLIMATE;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					248;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_NO_BREAKDOWN_SMOKE;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							0;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					39;
		weight:							0;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	default: 							sw_BR373TF;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_373TBF, 85) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			NO_CLIMATE;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					248;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_NO_BREAKDOWN_SMOKE;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							0;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					25;
		weight:							0;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	default: 							sw_BR373TBF;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_373MSb, 86) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			NO_CLIMATE;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					248;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_NO_BREAKDOWN_SMOKE;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							0;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					48;
		weight:							0;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	default: 							sw_BR373MSb;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

item (FEAT_TRAINS, item_373DMb, 87) {
	property {
		name: 							string(STR_NAME_BR373);
		climates_available: 			NO_CLIMATE;
		introduction_date:				date(1993,4,21);
		model_life:						8;
		retire_early:					1;
		vehicle_life:					50;
		reliability_decay:				7;
		refittable_cargo_classes:		0;
		cargo_allow_refit:				[PASS];
		loading_speed:					14;
		cost_factor:					248;
		running_cost_factor:			248;
		sprite_id:						SPRITE_ID_NEW_TRAIN;
		speed:							300 km/h;
		misc_flags:						TRAIN_FLAG_NO_BREAKDOWN_SMOKE;
		refit_cost:						0;
		track_type:						ELRL;
		ai_special_flag:				AI_FLAG_CARGO;
		power:							0;
		running_cost_base:				RUNNING_COST_ELECTRIC;
		dual_headed:					0;
		default_cargo_type:				PASS;
		cargo_capacity:					0;
		weight:							0;
		engine_class:					ENGINE_CLASS_ELECTRIC;
		tractive_effort_coefficient:	0.3;
		air_drag_coefficient:			0.1;
		length:							8;
		effect_spawn_model_and_powered:	EFFECT_SPAWN_MODEL_ELECTRIC;
		extra_weight_per_wagon:			0;
		bitmask_vehicle_info:			0;
	}
	graphics {
	can_attach_wagon:					CB_RESULT_ATTACH_ALLOW;
	default: 							sw_BR373DMb;
	colour_mapping: 					return PALETTE_CC_FIRST;
}
}

If anyone can work this out there is a cookie in it for you

[Leanden]

If it helps i've narrowed it down to these two switches:

[+] Spoiler

Code: Select all

switch(FEAT_TRAINS,SELF, sw_BR373TBK,cargo_subtype){
    0:	spriteset_BR373TBK_Eurostar;
	1:	spriteset_BR373TBK_GNER;
}

[+] Spoiler

Code: Select all

switch(FEAT_TRAINS,SELF, sw_BR373DMb,cargo_subtype){
    0:	spriteset_BR373DMb_Eurostar;
	1:	spriteset_BR373DMb_GNER;
}

I know this because no matter what spriteset I put for 1: it never changes from 0 to 1.

[frosch]

All vehicles with cargo subtypes need the "cargo_subtype_text" in the "graphics" section.
You can also see that in-game, when using the refit GUI and only selecting a single wagon, instead of the whole train.

[Leanden]

None of my other fixed consist trains have that, but I will try it

EDIT: I added the cargo_subtype_text to each of the vehicles, but no change to the sprites.

EDIT2: Looks like it isnt the switch itself at all. I tried to use the same switch as one of the working wagons on the faulty wagon and it still won't switch over.

[Leanden]

Ok i found the issue, apparently you can't refit vehicles which have a cargo capacity of 0

[The Growl]

Thanks for your help with upgrading.

But seriously, I love the brilliant new additions Leanden, not even on the latest version, yet I'm stuck for choice with what livery I should put my sprinter in, yet alone being able to choose a train. Keep up the great work!

[Doorslammer]

Thanks for your help with upgrading.

But seriously, I love the brilliant new additions Leanden, not even on the latest version, yet I'm stuck for choice with what livery I should put my sprinter in, yet alone being able to choose a train. Keep up the great work!

It's a lovely problem to have, isn't it?

[willsym22]

Hello, this looks absolutely fantastic
What do you have plans for including once its finished?
Thanks

[Leanden]

Hello, this looks absolutely fantastic
What do you have plans for including once its finished?
Thanks

To be honest i dont envisage that the set will ever be "finished".

I currently have graphics to include 132 trains (this includes variations for various different consists) and a smattering of rolling stock from 1829 until the present day. If people draw graphics to the same scale i will include them.

I dont plan to stop with trains however, i have plans for various other sets including but not limited to:

British Modular Stations (picking up from jvassies/mph/Daves unfinished set)
British Roads & Bridges (and Extras)
British Railway Tracks and Extras
British Buses
British Lorries
British Trams
British Industries
British Town Buldings

Can you see a theme here? I really want to produce a series of newGRF which can be used in conjunction to make a true balanced representation of transport in the UK. Its a tall task, but as you can see the coding is coming at a good pace, as long as i have graphics to accompany my work i will keep going.

[Pilot]

British Modular Stations (picking up from jvassies/mph/Daves unfinished set)
British Roads & Bridges (and Extras)
British Railway Tracks and Extras
British Buses
British Lorries
British Trams
British Industries
British Town Buldings

I sense that I may have a few games using graphics solely made by yourself in the future!

Also, are you aware that a lot of your image links appear to be broken?