Please make .patch (and .diff) files a text mime-type

Voice your opinions, concerns and suggestions on how to make the Transport Tycoon Forums better.

Moderator: General Forums Moderators

Post Reply
Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4763
Joined: 09 Sep 2007 05:03
Location: home

Please make .patch (and .diff) files a text mime-type

Post by Alberth »

My browser does not give me an option to open a patch file, instead it demands that I save it, which is quite annoying for a quick look.
'wget' tells me it gets sent as application/octet-stream, which explains why the browser behaves that way.

Code: Select all

Pragma: public
Content-Type: application/octet-stream
Content-Disposition: attachment; filename*=UTF-8''refit_vs_1.4.2.patch
Content-Length: 7886
Could it be set to "text/x-diff" or "text/x-patch" instead? We don't seem to be using binary patch files, so this should be safe.
Being a retired OpenTTD developer does not mean I know what I am doing.
User avatar
orudge
Administrator
Administrator
Posts: 25137
Joined: 26 Jan 2001 20:18
Skype: orudge
Location: Banchory, UK
Contact:

Re: Please make .patch (and .diff) files a text mime-type

Post by orudge »

.patch and .diff files are in the "plain text" attachment extension group in phpBB, but it seems that doesn't (directly) control MIME types. To change it would probably involve having to modify phpBB, unfortunately. I'll try to look into it though.
Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4763
Joined: 09 Sep 2007 05:03
Location: home

Re: Please make .patch (and .diff) files a text mime-type

Post by Alberth »

Sounds like a bug then :)
Being a retired OpenTTD developer does not mean I know what I am doing.
Post Reply

Return to “Forum Suggestions and Feedback”

Who is online

Users browsing this forum: No registered users and 2 guests